Repository navigation
Fix class_implements() on enum case objects (#5651) - #7312
Merged
Merged
Conversation
Resolve enum case operands to the declaring enum ClassEntry and map implicit unitenum/backedenum interfaces to UnitEnum/BackedEnum display names so class_implements(E::A) matches Zend and E::class. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
class_implements(E::A)on backed/unit enum cases now resolves the declaring enumClassEntry(TYPE_ENUM_CASE and enum-case objects) instead of returningfalseclassImplementsMap()maps implicitunitenum/backedenumregistry keys toUnitEnum/BackedEnumdisplay names (fixes enum type operands too, pairs Stdlib: class_implements() on enum must return UnitEnum/BackedEnum (ext/standard/basic_functions.c) #5422)Closes #5651
php-src reference
ext/standard/basic_functions.c—PHP_FUNCTION(class_implements), object branchZend/zend_enum.c— enum case objects implementUnitEnum/BackedEnumVerification
Issue repro (Zend vs VM):
Both emit
array(2) { ["UnitEnum"]=>... ["BackedEnum"]=>... }.Compliance + unit tests:
Output:
Test plan
class_implements_enum_case_object.phptcompliance caseClassImplementsBuiltinTest::testVmClassImplementsOnEnumCaseObjectMade with Cursor