[PurHur]

Summary

• Remove overly broad duplicate-modifier check in AsymmetricVisibilityCompileCheck::verifyPromotedParam() that rejected valid PHP 8.4 public private(set) constructor promotion
• Add compliance PHPT asymmetric_visibility_promoted_ctor.phpt and issue repro script
• Update unit test to expect compile success for promoted asymmetric visibility

php-src reference

• Zend/zend_compile.c — promoted parameter → property with asymmetric set visibility (RFC asymmetric-visibility-v2)
• PHP implementation: lib/Ast/AsymmetricVisibilityRewriter.php (source rewrite), lib/Compiler/AsymmetricVisibilityCompileCheck.php (validation), lib/Compiler.php (promotion lowering)

Verification

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php bin/vm.php test/repro/asymmetric_visibility_promoted_ctor.php
vendor/bin/phpunit --filter "AsymmetricVisibilityCompileCheckTest|asymmetric_visibility_promoted"
./script/ci-fast.sh --filter asymmetric_visibility_promoted
'

Output:

alice
Cannot modify private(set) property User::$name from global scope
OK (8 tests, 8 assertions)

Closes #6981

Made with Cursor