Repository navigation
Fix empty() on uninitialized typed properties — php-src parity (#6787) - #6873
Merged
Merged
Conversation
Zend returns true for empty() on uninitialized typed instance and static properties without throwing; revert #4912 throw semantics and guard VM/JIT lowering so uninitialized slots short-circuit to empty before read guards. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
empty()on uninitialized typed instance and static properties now returnstruewithout throwing, matching Zend/php-src (zend_object_handlers.c) and reverting Language: empty() on uninitialized typed property must throw Error (zend_object_handlers.c) #4912 throw semantics.emptyObjectProperty()andTYPE_EMPTYshort-circuit onTypedPropertyCheck::isUninitialized()before read/boolval.EmptyObjectPropertyHelperselectstruewhen slot type isTYPE_UNDEFINEDinstead of emittingTypedPropertyUninitGuard.empty_uninitialized_typed_property.phptupdated for php-src EXPECT.php-src reference:
Zend/zend_object_handlers.c,ext/standard/basic_functions.c(PHP_EMPTY)PHP implementation:
lib/VM.php,lib/JIT/EmptyObjectPropertyHelper.php,lib/JIT.phpCloses #6787
Test plan
Output (VM repro):
PHPUnit:
Made with Cursor