Repository navigation
Fix enum case method first-class callable E::A->f(...) (#6845) - #6860
Merged
Merged
Conversation
Closure::fromCallable rejected TYPE_ENUM_CASE array receivers; materialize the enum case object and infer enum class names for JIT FCC lowering. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClosureSupport::fromArrayCallable()materializesTYPE_ENUM_CASEreceivers viaEnumCaseSupport::receiverForInstanceMethod()soE::A->f(...)produces a working Closure (php-srczend_closures.c).FromCallableHelper/BoundMethodCallableHelperinfer enum FQCN fromTYPE_CLASS_CONST_FETCHwhen lowering bound-method FCC arrays.Closes #6845
php-src reference
Zend/zend_compile.c— first-class callable loweringZend/zend_closures.c— enum case method bindingVerification
Issue repro:
Output:
Targeted tests:
Output:
OK(12 tests including compliance.phpt).Made with Cursor