php-in-php: delete phpc_unserialize.c, LLVM via StringUnserializeJit (#5991) - #6643
Merged
Merged
Conversation
…5991) Replace AOT/JIT bitcode link of phpc_unserialize.c with PHP-owned LLVM lowering in lib/JIT/Builtin/StringUnserializeJit.php (scalar/array subset, phpc_session_decode_payload for session storage). Removes ~344 lines from lib/AOT/runtime/ and drops the TU from lib/AOT/Linker.php. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/AOT/runtime/phpc_unserialize.c(~344 lines) and remove it fromlib/AOT/Linker.phplib/JIT/Builtin/StringUnserializeJit.php— LLVM bodies for__compiler_unserializeandphpc_session_decode_payload(php-src:ext/standard/var_unserializer.csubset, Stdlib: unserialize() — VM + LLVM JIT/AOT #1175)StringUnserialize.phpnow delegates toStringUnserializeJitinstead of compiling/linking C bitcode at JIT link timeStringUnserialize::implementinType/String_.phpalongsideStringSerializeC runtime shrink
lib/AOT/runtime/phpc_unserialize.cVerification
Closes #5991
Made with Cursor