Skip to content

php-in-php: pack() PackEngine VM + delete phpc_pack.c from AOT link (#5231) - #6510

Merged
PurHur merged 1 commit into
masterfrom
agent/runtime-php-pack-5231
Jun 6, 2026
Merged

PurHur merged 1 commit into
masterfrom
agent/runtime-php-pack-5231

Conversation

@PurHur

@PurHur PurHur commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Summary

php-src reference

  • ext/standard/pack.c — php_pack()

Verification

rg phpc_pack lib/AOT/runtime   # empty
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit test/unit/PackEngineTest.php'
# OK (3 tests, 7 assertions)
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit test/unit/PackBuiltinTest.php --filter testVmPack'
# OK (1 test, 4 assertions)
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit test/unit/JIT/StringPackRuntimeStandaloneTest.php'
# OK (1 test, 4 assertions)
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit test/compliance/VMTest.php --filter pack 2>&1 | rg "stdlib pack"'
# stdlib pack() common format codes — green (`.` in VMTest output)
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php script/bootstrap-inventory.php --check'
# exit 0

Note: PackBuiltinTest::testAotNativeBinaryPack segfaults on compile in this harness on master too (pre-existing; not introduced here).

Closes #5231

Made with Cursor

#5231).

Move pack JIT/AOT to PackJitRuntime bitcode (lib/JIT/Builtin/pack_jit_runtime.c);
VM uses ext/standard/PackEngine.php instead of host pack().

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit 8ce3c55 into master Jun 6, 2026
@PurHur
PurHur deleted the agent/runtime-php-pack-5231 branch June 6, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

php-in-php: pack() JIT/AOT — delete lib/AOT/runtime/phpc_pack.c, lower from ext/standard/VmPack.php

1 participant