Repository navigation
Fix object array offset TypeError for isset/array_key_exists (#6500) - #6508
Merged
Merged
Conversation
Extend illegal-offset guards to reject plain objects and arrays on hash lookup paths so Zend-compatible TypeError replaces internal LogicException. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnumCaseSupport::rejectIllegalArrayOffset()to reject plain objects and arrays (not only enum cases) with Zend-compatibleTypeError: Illegal offset type.array_key_exists()/key_exists()VM builtin and JIT lowered paths to raiseTypeErrorinstead of internalLogicException/ silent false on object keys.isset()hashtable offset checks to emitTypeErrorfor object indices (matching VMoffsetIsSetmessage).test/compliance/cases/language/illegal_offset_object.phpt.php-src reference:
Zend/zend_hash.cillegal offset checks;ext/standard/array.carray_key_exists().Verification
Issue repro:
Output:
Targeted compliance:
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter illegal_offset_object test/compliance/VMTest.php'Result:
OK (1 test, 1 assertion)Regression (enum illegal offset):
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter enum_illegal_array_offset test/compliance/VMTest.php'Result:
OK (2 tests, 2 assertions)Closes #6500
Made with Cursor