Repository navigation
Language: DNF parameter (I1&I2)|C compiles — Op\Type\Intersection in TypeReconstructor (#4956) - #6391
Merged
Merged
Conversation
Ensure php-types overlays lower Op\Type\Intersection in TypeReconstructor so (I1&I2)|C parameters compile, and preserve class casing in DNF labels. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jun 5, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply-patches.shsophp-types-intersection-typeoverlay also lowersOp\Type\IntersectioninTypeReconstructor::resolveOpType()(previously onlyType.phpwas patched; Union_ without Intersection caused compile failure on(I1&I2)|Cparameters).TypeReconstructor.phpwith the Intersection handler.(I1&I2)|Cnot(I1&I2)|c) for Zend-matching TypeError messages.Closes #4956
php-src reference
Zend/zend_compile.c—zend_compile_type, DNF normalizationZend/zend_type.h— parameterzend_typeDNF listsPHP implementation:
script/apply-patches.sh(vendor overlay),lib/DnfType.php(label formatting), existinglib/VM/DnfCheck.phpruntime checks.Verification
Made with Cursor