Language: enum case === / == with backing scalar must be false (#5798) - #5802
Merged
Merged
Conversation
Reject === and == between enum cases and non-case operands in Variable compare helpers so looseEqual cannot coerce backing values. Add maintainer repro and EnumVMTest PHPT guarding Zend behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
===/==when exactly one operand is an enum case (Variable::identicalTo/equals), matching Zendzend_operators.c— avoids anylooseEqualnumeric coercion path.test/repro-maintainer/parity_enum_strict_identity.phpand compliance PHPTenum_compare_backing_scalar.phpt.php-src reference:
Zend/zend_operators.c(compare_functionenum case vs scalar).Verification
Closes #5798
Made with Cursor