Repository navigation
Bootstrap: VM scandir() via VmDir opendir/readdir (#5048) - #5778
Merged
Merged
Conversation
Replace host \scandir() in ext/standard/scandir.php with VmDir::scandir() built on the existing opendir/readdir/closedir helpers. Supports SCANDIR_SORT_ASCENDING/DESCENDING/NONE for M5 bootstrap without calling Zend scandir from the VM builtin path. Verification: ./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && ./vendor/bin/phpunit test/compliance/VMTest.php --filter glob_scandir && ./vendor/bin/phpunit test/unit/VmFsGlobTest.php' Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scandir()no longer calls host\scandir(); usesVmDir::scandir()on the opendir/readdir/closedir stack (Bootstrap: scandir() VM — native directory listing without host PHP #5048).SCANDIR_SORT_ASCENDING,SCANDIR_SORT_DESCENDING, andSCANDIR_SORT_NONElike Zend.VmFsGlobTestasserts no host\scandir(in builtin source and fixture listing works.Closes #5048
php-src reference
ext/standard/dir.c—php_scandir/php_scandir_exVerification
Output:
Note on #5771
Lane C issue #5771 (enum
(array)cast) already passes on master (#5536); closing separately.Made with Cursor