Repository navigation
Language: enum implements interface — inherit interface class constants (#5725) - #5746
Merged
Merged
Conversation
Enums implementing an interface now inherit interface constants on VM and JIT, matching Zend E::X resolution for unit and backed enums. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enums that
implementsan interface now inherit interface class constants on VM and JIT, matching ZendE::Xresolution (php-srcZend/zend_enum.c/zend_interfaces.c).inheritFromInterfaces()after enum body materialization inTYPE_DECLARE_ENUMclassImplementsand callinheritInterfaceConstants()for enums (same path as classes)php-src reference
Zend/zend_enum.c— enum implements interfaceZend/zend_interfaces.c— inherited constantsVerification
Issue repro:
Compliance:
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter enum_interface_const'Closes #5725
Made with Cursor