Repository navigation
Language: first-class callables yield Closure objects (#4810) - #4961
Merged
Merged
Conversation
Lower strlen(...), Class::m(...), and [$o,'m'](...) via TYPE_FROM_CALLABLE using ClosureSupport::fromCallable on the VM and FromCallableHelper on JIT. Resolve indirect values in is_object() so object checks match instanceof. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TYPE_FROM_CALLABLEsostrlen(...),Class::m(...), and[$o,'m'](...)lower to realClosureinstances viaClosureSupport::fromCallable(Zendzend_create_closure()parity).FromCallableHelperwraps compile-time callables withclosureCallproxies (no string/array invoke folding).is_object()VM path toresolveIndirect()so object checks matchinstanceofon boxed variables.php-src reference:
Zend/zend_compile.c(zend_compile_first_class_callable),Zend/zend_closures.c(zend_create_closure).Verification
./script/docker-exec.sh -- bash -lc 'php test/tmp/repro-fcc-closure-object.php; php bin/vm.php test/tmp/repro-fcc-closure-object.php'./script/docker-exec.sh -- bash -lc 'vendor/bin/phpunit --filter first_class_callable_closure_object 2>&1'./script/docker-exec.sh -- bash -lc 'vendor/bin/phpunit --filter "VMTest::testCases.*first_class_callable[^_]" 2>&1'Closes #4810
Made with Cursor