Repository navigation
Language: keyed list destructuring with spread (#4889) - #4896
Merged
Merged
Conversation
Track compile-time string keys consumed before ...$tail, merge the remaining assoc entries in VM spread assign, and group keyed+spread lowering with TYPE_LIST_UNPACK_CHECK like numeric spread (#4835). Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
['label' => $label, ...$rest] = $assocVM parity for issue #4889:listSpreadExcludedKeys)TYPE_LIST_SPREAD_ASSIGNcopies remaining entries (assoc tail) instead of requiring a packed list when keys were excludedTYPE_LIST_UNPACK_CHECKblock (same as numeric spread Language: list destructuring with spread — [$a, ...$rest] = $arr (zend_compile.c) #4835)php-src reference:
Zend/zend_compile.czend_compile_list_assignkeyed + unpack semantics.JIT spread lowering remains #4885 (phase 2).
Verification
Output:
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && ./vendor/bin/phpunit --filter list_destructuring_keyed_spread test/compliance/VMTest.php'Related regressions:
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && ./vendor/bin/phpunit --filter "list_destructuring_spread|keyed_list_destruct" test/compliance/VMTest.php'Closes #4889
Made with Cursor