Repository navigation
Language: E_WARNING for array offset on scalars (#4867) - #4884
Merged
Merged
Conversation
Zend ZEND_FETCH_DIM_R on null/bool/int/float emits a warning and yields null instead of TypeError. VM and JIT read paths match; object dim fetch raises catchable Error with the php-src message. Reference: php/php-src Zend/zend_execute.c Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TYPE_ARRAY_DIM_FETCHread on null/bool/int/float: emit Zend-styleE_WARNING(Trying to access array offset on value of type …) and yieldnullinstead ofTypeError(php-srcZend/zend_execute.c).ScalarDimFetchHelperwith__compiler_trigger_error+ null box.ArrayAccessobject offset read raises catchableError(Cannot use object of type … as array).array_offset_scalar_warning.phpt;dim_fetch_null_type_error.phptnarrowed to read-only cases (write parity tracked separately).Closes #4867
Reference
php/php-src
Zend/zend_execute.c(ZEND_FETCH_DIM_R on scalars)Verification
./script/docker-exec.sh -- bash -lc 'vendor/bin/phpunit --filter "array_offset_scalar_warning|dim_fetch_null_type_error" test/compliance/'Made with Cursor