Stdlib: array_key_exists() TypeError for non-array second argument (#4722) - #4762
Merged
Merged
Conversation
Use VmArray/JitArrayElem requireArrayParam helpers so VM and AOT/JIT paths raise Zend-matching TypeError instead of LogicException; report object class names in VmArray type labels for parity with php-src. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LogicExceptionwith Zend-matchingTypeErrorwhenarray_key_exists()receives a non-array second argument (VM viaVmArray::requireArrayParam, JIT/AOT viaJitArrayElem/TypeErrorRaise).object) inVmArray::valueTypeLabel()for php-src parity on array param errors.php-src reference:
ext/standard/array.c—PHP_FUNCTION(array_key_exists)/Z_PARAM_ARRAYCloses #4722
Verification
Output (Zend + VM match):
AOT lint + abort on non-array string operand:
Test plan
array_key_exists_non_array.phptarray_key_exists_non_array.phpt(exit 134)array_key_exists*tests green (5/5)Made with Cursor