Repository navigation
Language: list destructuring from null — targets stay unset (#4325) - #4330
Merged
Merged
Conversation
…). Guard list() / [] groups with TYPE_LIST_UNPACK_CHECK CFG so non-array RHS skips dim-fetch assignments (Zend zend_execute.c parity). JIT LLVM verify covers the new branch; MCJIT execute remains gated like other list unpack paths. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list()/[]destructuring groups inTYPE_LIST_UNPACK_CHECKCFG lowering so non-array RHS (null,false,0) skips dim-fetch assignments instead of throwing "Illegal offset" (Zendzend_execute.cparity).php-src reference
Zend/zend_execute.c— list assignment on non-array typesVerification
Closes #4325
Made with Cursor