Repository navigation
Language: JIT yield from nested Generator (#4014) - #4032
Merged
Merged
Conversation
GeneratorHelper already lowers nested `yield from inner()` via emitYieldFromGeneratorIter (#3074). Update capability matrix notes, regenerate capabilities-syntax.md, and add a gated MCJIT execute test matching the issue repro (skipped when jit-runtime-probe fails). Verification: ./vendor/bin/phpunit --filter generator_yield_from ./vendor/bin/phpunit test/unit/GeneratorJitCompileTest.php Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4014. Nested
yield from inner()generator delegation was already implemented inlib/JIT/GeneratorHelper.phpviaemitYieldFromGeneratorIter(#3074). This PR:yield fromarray and generator delegation; try/catch in generator bodies remains deferreddocs/capabilities-syntax.mdGeneratorJitExecuteTest::testYieldFromGeneratorForeachExecutesViaMcjit(gated byjit-runtime-probe, same as existing generator execute tests)php-src reference:
Zend/zend_generators.c(zend_generator_yield_from)Verification
MCJIT execute via
bin/jit.phpstill segfaults in this LLVM 9 harness for all scripts (pre-existing #98/#2114);GeneratorJITTest/GeneratorJitCompileTestguard IR viacompile.php -l.Made with Cursor