Language: Ternary operator (?:) — lint parity and VM compliance (#114) - #403
Merged
Conversation
php-cfg lowers ?: to JumpIf/Phi before compile; VM and JIT already handle TYPE_JUMPIF. Remove stale lint registry entry and add regression coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?:is already lowered by php-cfg toStmt_JumpIf+ phi merge beforeCompilerruns; VM and JIT use existingTYPE_JUMPIFlowering.Expr_Ternaryentry fromUnsupportedRegistryanddocs/unsupported-syntax.mdsophpc lintno longer reports a false unsupported gap.test/compliance/cases/language/ternary.phptfor truthy/falsy and comparison guards.Test plan
vendor/bin/phpunit test/compliance/VMTest.php test/unit/UnsupportedRegistryTest.php(Dockerphp-compiler:22.04-dev)php bin/lint.php -r 'echo (1 ? 2 : 3);'exits 0Closes #114
Made with Cursor