Language: ArrayAccess JIT/AOT offset dispatch (#4012) - #4017
Merged
Merged
Conversation
Add ArrayAccessHelper for offsetGet/Set/Exists/Unset via runtime instance method dispatch, remove ArrayAccess from requiresVmLowering, and guard compile/AOT with lint + LLVM verify tests. MCJIT execute remains skipped in JITTest (segfault, same class as SplObjectStorage). php-src: Zend/zend_object_handlers.c read_dimension / write_dimension Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArrayAccessHelperfor JIT/AOT$obj[$key]read/write/isset/unset viaoffsetGet/offsetSet/offsetExists/offsetUnsetinstance dispatch (RuntimeIndirectInstanceMethodCall).containsArrayAccessObjectOpcodesfromBlock::requiresVmLoweringsobin/jit.phpno longer VM-fallbacks solely for ArrayAccess.RuntimeIndirectInstanceMethodCall/JitValueBox::coerceToValuePtrForStorewhen user methods return__value__struct vs__value__*.php-src reference:
Zend/zend_object_handlers.c(zend_std_read_dimension,zend_std_write_dimension)Verification
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && ./vendor/bin/phpunit --filter "array_access|ArrayAccess"'./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && ./vendor/bin/phpunit --filter ArrayAccessJitCompileTest'./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && ./vendor/bin/phpunit --filter ArrayAccessJITTest'Note: MCJIT execute for ArrayAccess still segfaults (LLVM 9);
JITTestskipsarray_access*execute — same pattern asSplObjectStorageJITTest(lint + LLVM verify green).Closes #4012
Made with Cursor