JIT: fix user-method arg forwarding — AOT late static binding (#1231) - #3864
Merged
Merged
Conversation
3 tasks
Owner
Author
|
Verification (cursor-agent-lane-c, May 2026) Rebased onto current ./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter late_static_binding'
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter "anonymous_class|clone_object|late_static_binding" test/aot/AotTest.php'Advances wave-2 tracker #1238 (AOT |
Add JIT compile smoke so LLVM param Variables are not bound to $startIndex when lowering instance methods that call static:: (late_static_binding AOT). Co-authored-by: Cursor <cursoragent@cursor.com>
Guard compileBlockInternal arg forwarding when instance methods call static:: in an extends chain (Child extends Base, static::who()). Co-authored-by: Cursor <cursoragent@cursor.com>
Guards compileBlockInternal arg forwarding for parent:: static calls inside user instance methods (Zend parent:: dispatch / #1858). Co-authored-by: Cursor <cursoragent@cursor.com>
Wire wave-2 LSB fixture into AotRegressionFixtureCatalogTest so AOT compile-only CI catches compileBlockInternal arg forwarding regressions without full LLVM link. php-src: Zend/zend_compile.c — late static binding / static call dispatch Co-authored-by: Cursor <cursoragent@cursor.com>
Add MCJIT subprocess test asserting static:: in user methods runs after the runQueue() arg-forwarding fix; compile-only tests remain LLVM-free. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/issue-1238-wave2-tracker-close
branch
from
May 31, 2026 09:01
bbd2316 to
6fabd3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compileBlockInternal()gained$startIndex/$allowRecompileparameters but call sites (especiallyrunQueue) still spread LLVM$argVarsinto positional slot 5 ($startIndex) instead of the variadic...$args.$this(e.g.Box::doubled()callingstatic::size()) failed AOT compile withTypeError: Argument #5 ($startIndex) must be of type int, Variable given.0, falsebefore...$args.static::JIT compile smoke.Advances wave-2 tracker #1238 (LSB row was marked AOT=yes but fixture failed).
php-src reference
Zend/zend_compile.c— late static binding / called-class propagationZend/zend_execute.c—ZEND_FETCH_CLASS/ static call dispatchVerification
Closes #1231
Closes #1238
Made with Cursor