Language: Generator::send() and Iterator API on VM (#167) - #3831
Merged
Conversation
Wire yield expression result slots from the compiler, inject send values
on resume, and register Generator::{send,rewind,current,key,valid,next}.
Fix LintCompiler::compileClassBody signature after sealed-class (#3335).
php-src: Zend/zend_generators.c (zim_Generator_send, generator resume).
Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
Register Generator::throw(), dispatch exceptions into generator try/catch with generatorState preserved on catch frames, and propagate uncaught throws to the caller via executeInternalHandler (Zend zend_generators.c). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generator::{send,rewind,current,key,valid,next}and injectssend()values into the yield-expression result slot (Compiler+VM::resumeGenerator).generator_send.phpt(rewind → current → send → getReturn).LintCompiler::compileClassBodysignature regression from sealed classes (Language: sealed classes — parse + VM inheritance guard (#3322) #3335) that brokeMINIWEBAPP_LINT_ZERO_GATE.php-src reference
Zend/zend_generators.c—zim_Generator_send, generator resume / yield value receiveVerification
Part of umbrella #167 (VM
send/Iterator surface). JIT/AOT generators remain in #3074 / #3115 — do not close #167 until those land.