Language: throw expressions (PHP 8.0) — ?:, ??, && lowering (#3802) - #3821
Merged
Merged
Conversation
Fix duplicate New lowering before Throw, allocate throw objects outside ?: merge phi slots, and skip unreachable CFG ops after throw-expr. Adds compliance coverage and capability-syntax entry for PHP 8.0 throw expressions. php-src: Zend/zend_compile.c zend_compile_throw(), zend_language_parser.y Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?:), null-coalesce (??), and short-circuit (&&) contextsNew_beforeThrow_, allocate throw objects on a fresh slot (avoid?:merge phi collision), and drop unreachable CFG ops after throw?? throwRHS throughcompileThrowExpression()with entry-blockNew_lookuptest/compliance/cases/language/throw_expression.phptand capability-syntax entryphp-src reference
Zend/zend_compile.c—zend_compile_throw()from expression compile pathsZend/zend_language_parser.y—T_THROW exprin expression grammarVerification
Existing vendor patches (
php-cfg-throw-expr.patch,php-types-throw-expr.patch) provide parse/type-reconstruction support; no new vendor edits in this PR.Notes
coalesce_throw.phpt(Language: null coalesce throw — ($x ?? throw new Exception()) (Zend zend_compile.c parity) #3462) with userExclass still fails constructor frame setup (pre-existing);LogicExceptionpath works?:arm exits non-zero with VM exception message (matches prior throw behavior)Closes #3802
Made with Cursor