Stdlib: extract() and compact() for template includes (#275) - #373
Merged
Merged
Conversation
Caller frames are linked for internal builtins so string-keyed arrays can populate compiled locals (EXTR_SKIP). JIT/AOT lowering is deferred; compliance covers the VM path. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extract()andcompact()on the VM path for string-keyed arrays and literalcompact()name lists.Framewhen invoking internal builtins so scope import targets the correct compiled locals.extract_compact,extract_skip) and register builtins inext/standard/Module.php.JIT / AOT
JIT lowering is not enabled yet (
not implemented for JIT);JITTestskips the new PHPT cases until LLVM scope import is stable (follow-up on #275). VM acceptance matches the issue:Test plan
script/ci-local.shVM/compliance slice (195 VM PHPT cases OK)bin/vm.phpextract smokeextract/compact(tracked in Stdlib: extract() and compact() for PHP template includes #275)Closes #275
Made with Cursor