Skip to content

Foundation: stop false Applied claims from warm apply-patches (#36229) - #36514

Merged
PurHur merged 1 commit into
masterfrom
fix/36229-overlay-applied-honesty
Sep 3, 2026
Merged

Foundation: stop false Applied claims from warm apply-patches (#36229)#36514
PurHur merged 1 commit into
masterfrom
fix/36229-overlay-applied-honesty

Conversation

@PurHur

@PurHur PurHur commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Summary

Test plan

  • ./script/docker-exec.sh -- bash -lc 'script/apply-patches.sh' → exit 0, 0 Applied lines on warm tree
  • ./script/docker-exec.sh -- bash -lc 'script/apply-patches.sh --verify-pristine' → OK, php-llvm stack 27/27
  • ./script/phpunit.sh --filter ApplyPatchesTest → 45/45 (1 skipped), includes testWarmApplyPatchesDoesNotClaimAppliedWithoutMutation
  • ./script/aot-smoke.sh → 9/9, size gate OK

Fix over-escaped patch_already_applied markers, cmp-skip identical overlay
file copies, and sync prelinked TypeReconstructor to the resolver-worklist
end-state so a second apply-patches run mutates nothing.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant