Tooling: Definition of Done gate rejects bare Closes #N (#36400) - #36450
Merged
Conversation
Require a full ticked Done-when copy in the PR body before Closes, add the PR template + weekly closed-but-partial audit, and wire a self-test into CI. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONTRIBUTING.mdand.github/PULL_REQUEST_TEMPLATE.md(Process: Definition of Done — a PR may say "Closes #N" only when every Done-when box is checked; otherwise "Part of #N"; PR template + a scope-check gate + a weekly "closed but not done" audit (CONTRIBUTING.md, .github/PULL_REQUEST_TEMPLATE.md, script/check-issue-close-scope.php) #36400).script/check-issue-close-scope.phprejectsCloses #Nunless every Done-when box is ticked in the PR body;Part of #Nis allowed for partials. Wired intoci-common.shviaISSUE_CLOSE_SCOPE_GATEself-test.script/audit-closed-but-partial.php— first run posted on Wave 2 (Sep 2026): from a working compiler to a compiler people use — install, real projects, speed, trust — automation tracker #36379 with umbrella child Respin queue from #36400 closed-but-partial audit (2026-09-03) #36449.Closes #36400
Done when (from #36400)
needs-respinfrom it has a fresh child issueTest plan
php script/check-issue-close-scope.php --self-test→ OK (reject bare Closes; accept ticked; accept Part of)./script/phpunit.sh --filter IssueCloseScopeTest→ 4/4php script/audit-closed-but-partial.php --days 3 --post --tracker 36379→ umbrella Respin queue from #36400 closed-but-partial audit (2026-09-03) #36449 + comment on Wave 2 (Sep 2026): from a working compiler to a compiler people use — install, real projects, speed, trust — automation tracker #36379./script/aot-smoke.shwas 9/9 on master before this docs/tooling change;make north-star5-verify-fastOK on master (gates unchanged)