Skip to content

Close #36407: mandelbrot timeout resolved — bless bench-gate + differential pin - #36427

Merged
PurHur merged 1 commit into
masterfrom
agent/issue-36407-mandelbrot-bench-gate
Sep 2, 2026
Merged

PurHur merged 1 commit into
masterfrom
agent/issue-36407-mandelbrot-bench-gate

Conversation

@PurHur

@PurHur PurHur commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Confirms wave-1 mandelbrot timeout regression is fixed on master (allocator thrash from broken delref/dtor CFG reverted in Fix AOT function-scoped array append segfault (revert #36314 delref dtor CFG) #36331).
  • Refreshes benchmarks/BASELINE.json from pinned php-compiler:22.04-dev so script/bench-gate.sh is green again.
  • Adds test/differential/cases/i36407_mandelbrot_float_while.php to pin the Julia float-while loop shape.

Root cause (bisect)

Between 4eed6a2785 and 1edb103c34, #36215 wired HashTable/Object dtors into __ref__delref; the broken CFG caused per-iteration alloc/free in mandelbrot's float loop (51s sys). Reverted in #36331 (8821c429de).

Done-when

Verify

script/bench-gate.sh
# bench-gate: OK (ratio <= +30%, ir_lines <= +20% vs baseline)
# mandelbrot 0.0896s, simple 0.1442s

script/differential-sweep.sh --dir build/diff36407 --aot --repeat 3
# ok i36407_mandelbrot_float_while.php (3/3 runs) — 1/1 match Zend

make dev-verify-fast
# OK (80s): aot-smoke 9/9, VM tier-0 15/15

make north-star5-verify-fast
# OK (fast)

Closes #36407

Made with Cursor

Wave-1 mandelbrot timeout (>60s, 51s sys) was fixed on master by reverting
the broken delref/dtor CFG (#36331); absolute targets are now met (mandelbrot
0.09s, simple 0.14s). Refresh benchmarks/BASELINE.json from pinned image and
add a differential case for the Julia while-loop shape.

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit c5b2ee8 into master Sep 2, 2026
@PurHur
PurHur deleted the agent/issue-36407-mandelbrot-bench-gate branch September 2, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant