Close #36407: mandelbrot timeout resolved — bless bench-gate + differential pin - #36427
Merged
Merged
Conversation
Wave-1 mandelbrot timeout (>60s, 51s sys) was fixed on master by reverting the broken delref/dtor CFG (#36331); absolute targets are now met (mandelbrot 0.09s, simple 0.14s). Refresh benchmarks/BASELINE.json from pinned image and add a differential case for the Julia while-loop shape. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
benchmarks/BASELINE.jsonfrom pinnedphp-compiler:22.04-devsoscript/bench-gate.shis green again.test/differential/cases/i36407_mandelbrot_float_while.phpto pin the Julia float-while loop shape.Root cause (bisect)
Between
4eed6a2785and1edb103c34, #36215 wired HashTable/Object dtors into__ref__delref; the broken CFG caused per-iteration alloc/free in mandelbrot's float loop (51s sys). Reverted in #36331 (8821c429de).Done-when
script/differential-sweep.sh --aot --repeat 3on new case: 1/1Verify
Closes #36407
Made with Cursor