Build: commit helper-runtime common.o + prelink gate (#36246 follow-up) - #36423
Merged
Conversation
…-up) Publish the shared runtime prologue from the ctype anchor unit, extend check-helper-runtime-prelink to report common.o freshness, and preserve arch manifest fields when merging common metadata. Linking stays opt-in (PHP_COMPILER_HELPER_RUNTIME_COMMON=1) until units are re-emitted with AotGcSections — auto-link currently segfaults aot-smoke. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prelinked/helper-runtime/x86_64-linux/common.o(+common.bc) from the ctype anchor unit viascript/emit-helper-runtime-common.php --from-prelinkedcheck-helper-runtime-prelink.phpto reportcommon.ofreshness (strict fails when manifest expects common but object is missing/stale)HelperRuntimeCommon::publishManifestMetadata()to merge common fields without overwriting arch-levelcore_fingerprint/ unit metadatamake helper-runtime-common-publishtargetLinking
common.oremains opt-in (PHP_COMPILER_HELPER_RUNTIME_COMMON=1) until helper units are re-emitted withAotGcSections— auto-link was tested and causes aot-smoke segfaults (139) because the anchor copy still embeds helper exports, not a runtime-only prologue.Closes #36246 (remaining deliverable: committed common.o artifact + gate; full size win blocked on gc-sections unit re-emit).
Test plan
./script/aot-smoke.sh→ 9/9, size gate OKmake dev-verify-fast→ OK (81s)./script/docker-exec.sh -- bash -lc 'php script/check-helper-runtime-prelink.php'→ 400 fresh, 46 stale, common.o fresh./script/phpunit.sh --filter HelperRuntimeCommonTest→ 4/4 OK--prelinkgc-sections re-emit (446 units) — follow-up; not in this PRMade with Cursor