Runtime: undefined array/superglobal key — Zend notice parity (#273) - #364
Merged
Conversation
Emit Zend-style warnings on missing string keys in VM and JIT/AOT hashtable reads while still yielding null; document semantics and add PHPT plus unit coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Warning: Undefined array key "…"on missing string/integer keys while reads still returnnull(PHP 8 parity).__hashtable__readStringKeyValuevia__compiler_undefined_array_key_warning_cstr.docs/runtime-semantics.md; add PHPTundefined_array_key_getandUndefinedArrayKeyTest.Test plan
php vendor/bin/phpunit --exclude-group llvm,serve(378 tests) inphp-compiler:22.04-devtest/real/RealWorldTestincludes new PHPTphp bin/compile.php -o /tmp/t -r '$x=$_GET["n"];'→ stderr warning on runCloses #273
Made with Cursor