Fix: array_map dim-fetch haystack over prior FuncCall (#36355) - #36362
Merged
Conversation
…6355) array_map('intval', $data['scores']) after json_decode()/get() wired the outer array (ARG_SEND of EXEC_RETURN) because leadingCallbackFirstHaystack preferred the preceding FuncCall over the intervening ArrayDimFetch. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$data = json_decode(...); array_map('intval', $data['scores'])mapped the outer assoc array (1,1from array+bool) becauseleadingCallbackFirstHaystackFuncCallBeforeCfgCallbound haystack ARG_SEND to the prior FuncCall EXEC_RETURN instead of the interveningArrayDimFetch.array_maphaystack arg Php stdlib specs implementation #1, preferresolvePrecedingArrayDimFetchCallArgSlotbefore the FuncCall producer path.ext/standard/array.c—PHP_FUNCTION(array_map)/Z_PARAM_ARRAYfor$array.Closes #36355
Verification
Not covered: inline
implodeinsidesprintfarg list (sibling #36353 shape); fulldifferential-sweep.sh --aot --repeat 3.Made with Cursor