CI: surface apply-patches failures in selfhost-preflight (#36247) - #36312
Merged
Merged
Conversation
Remove the bootstrap preflight || true swallow so patch drift fails M4/M5 probes; add CiScriptsTest guards and drop "Actions disabled" doc wording. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
|| trueswallow inselfhost_apply_patches_if_needed— bootstrap/M4 probes now fail when vendor patches cannot apply (same fast--verify-onlypath asci-memory-env.sh).CiScriptsTestguards for selfhost-preflight andci-common.shapply-patches wiring.Closes #36247 (partial — GHA workflow split / image cache / branch protection remain tracked on #36188).
Verification
Not run: full
north-star5-verify-fast(master was green pre-change; dev-verify-fast covers aot-smoke + VM tier-0).Made with Cursor