Foundation: bench-gate catches AOT performance regressions (#36196) - #36300
Merged
Conversation
Introduces script/bench-gate.sh comparing AOT/Zend wall-time ratios and LLVM IR size against benchmarks/BASELINE.json. Gate is intentionally red on fibo(30) until typed-int boxing is fixed; wired as compiler-gate tier 3. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
script/bench-gate.sh+script/bench-gate.php— compares AOT/Zend wall-time ratios (best-of-3, same job) and LLVM IR line counts againstbenchmarks/BASELINE.jsonbenchmarks/README.md(2026-07-27 table); IR counts from pinnedphp-compiler:22.04-devcompiler-gate.ymlforlib/JIT/**,lib/AOT/**,ext/standard/**path triggersGate behavior (intentionally red)
The gate fails on today's master for
fibo(30)— proof it bites before the typed-int boxing fix (#36189 / #31980):mandelbrotalso regressed (separate issue). Gate goes green after perf fixes +--update.Test plan
./script/phpunit.sh --filter BenchGateTest— 4/4 OKmake dev-verify-fast— OK (91s)./script/bench-gate.sh— exit 1, fibo(30) ratio regression reported (as designed)make north-star5-verify-fast— not run (tooling-only change)Closes #36196
Made with Cursor