Codegen: outline __value__copy once per module (#36193) - #36296
Merged
Conversation
Replace 176 open-coded 15-block copyBetweenPointers expansions with a single lazy-linked __value__copy runtime helper (VmValueCopy SSOT). Verified: aot-smoke 9/9; dev-verify-fast OK; north-star5-verify-fast OK; echo IR lines 117653→91133; ValueBoxCopyOutlineTest 4/4. Co-authored-by: Cursor <cursoragent@cursor.com>
…#36193) Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/issue-36193-value-copy-outline
branch
from
September 2, 2026 06:03
9f96386 to
64a8691
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copyBetweenPointerstype-switch expansions (15 basic blocks each) with a single lazy-linked__value__copyhelper per LLVM modulelib/VM/VmValueCopy.php; JIT trampoline:lib/JIT/Builtin/ValueBoxCopyJit.php; call sites inJitValueBoxbecome onecallCloses #36193
Test plan
Made with Cursor