JIT: cache __value__ type tags in emitBoxedNumericResult (#36217) - #36289
Merged
Conversation
Load each operand's type byte once for promotion checks and float conversion instead of reloading via valueIsDouble/valueBoxToDouble. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__value__::typebyte once inemitBoxedNumericResultfor promotion checks and float conversionvalueBoxToDoubleWithTypeByte,loadTypeByte,typeByteIsDouble,typeByteIsStringhelpers__value__with per-op type dispatch — add guarded speculation (unboxed i64 loop phis, unboxed call arguments) with the generic path as bail-out (lib/JIT.php, lib/JIT/JitValueNumeric.php, lib/JIT/Call/Native.php) (re-#23483) #36217 (tag caching) toward reducing per-op type dispatch in untyped arithmeticCloses #36217 (partial — loop-counter and call-argument speculation remain follow-ups)
Test plan
Not run: full
script/differential-sweep.sh --aot --repeat 3(no lowering semantics change expected; tag loads are CSE-equivalent)Made with Cursor