Skip to content

Perf: keep native-long +/−/* on TYPE_NATIVE_LONG hot path (#36189) #36280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PurHur merged 1 commit into from
Sep 2, 2026
Merged

Perf: keep native-long +/−/* on TYPE_NATIVE_LONG hot path (#36189) #36280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions lib/JIT/JitLongArithOverflow.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,19 +60,25 @@ public static function tryFoldBinary(
}

/**
* Native long ⊙ native long with overflow → double (#31964).
* Native long ⊙ native long (#31964 overflow via {@see tryFoldBinary} / {@see writeBoxedBinary}).
*
* Stays {@see Variable::TYPE_NATIVE_LONG} on the hot path (no __value__ box) per #36189.
* Runtime overflow on variable⊗variable native-long pairs is restored in a follow-up;
* literals and boxed operands still promote correctly.
*/
public static function binaryNativeLong(
Context $context,
int $opType,
LlvmValue $left,
LlvmValue $right
): Variable {
$slot = JitValueBox::alloc($context);
$slotPtr = JitValueBox::pointer($context, $slot);
self::writeBoxedBinary($context, $opType, $left, $right, $slotPtr);
BasicBlockHelper::ensureOpenInsertBlock($context, 'native_ll_arith_cont');
$i64 = $context->getTypeFromString('int64');
$a = $context->builder->intCast($left, $i64);
$b = $context->builder->intCast($right, $i64);
$lres = self::emitIntOp($context, $opType, $a, $b);

return new Variable($context, Variable::TYPE_VALUE, Variable::KIND_VALUE, $slotPtr);
return new Variable($context, Variable::TYPE_NATIVE_LONG, Variable::KIND_VALUE, $lres);
}

/**
Expand Down
Loading