AOT: string assignment uses addref instead of eager memcpy (#36192) - #36279
Merged
Merged
Conversation
Value-box string copies now share refcounted __string__ like Zend zend_string_copy, fixing O(n) memcpy on every $u = $s assignment. Mutation paths still use __string__separate / __ref__separate for writes. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$u = $s, boxing native strings,coerceToValuePtrForStore) now call__ref__addrefinstead of__string__separate(Zendzend_string_copysemantics).__string__separateremains for mutation / hashtable-key ownership paths.Verify
Closes #36192
Made with Cursor