CI: fix simplifier use-chain overlay re.sub backslash escape (#36250) - #36264
Merged
Merged
Conversation
The #36257 overlay used re.sub with a replacement string containing Op\Phi; Python treats \P as an invalid escape. Use a lambda replacement instead. Verified: ./script/apply-patches.sh OK, make dev-verify-fast OK (105s). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
script/apply-patches.shregression from Foundation: fix Simplifier use-chain guard for July-5 partial trees (#36250) #36257: the simplifier use-chain overlay calledre.sub(new_replace_variables, …)where the replacement string containsOp\Phi; Python'sre.subtreats\Pas an invalid escape and aborts withre.error: bad escape \P.Closes #36250 (regression re-open via lane overflow on #36142).
Test plan
Made with Cursor