VM: emit Zend-shaped fatals on stderr instead of silent exit 255 (#36208) - #36240
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
php_compiler_cli_write_fatal_stderr/php_compiler_cli_fatal_exithelpers and routebin/vm.php/src/cli_driver.phpLogicException paths through stderr (not stdout).PHP Fatal error:lines for compile-timeLogicExceptioninRuntime::emitParseCompileFailureStderr.test/BaseTest.php), differential sweep, and bench now run VM witherror_reporting=1,log_errors=1,display_errors=stderrso OOM fatals are visible.Closes #36208
Test plan
./script/phpunit.sh --filter VmCliFatalStderrTest— OK (3 tests, 13 assertions)./script/phpunit.sh --filter 'VmCliFatalStderrTest|CompileFatalDiagnosticShapeTest|MissingTraitFatalQuotesTest'— OK (11 tests, 36 assertions)make dev-verify-fast— OK (aot-smoke 8/8, VM differential tier-0 15/15)make north-star5-verify-fast— not re-run this push (passed earlier on same diff)Made with Cursor