Repository navigation
Split-TU: fast-exit after SPINE_CHUNK AOT emit (#36155) - #36234
Merged
Merged
Conversation
Spine hub/consumer chunk compiles set PHP_COMPILER_SPINE_CHUNK=1 but bin/compile.php classifies build/micro/chunk paths as user-script AOT and clears SELFHOST_AOT, so post-emit LLVM teardown could spin 15+ min after -o was already linked (#31726). Extend AotEmitFastExit and the compile.php belt-and-suspenders path to treat SPINE_CHUNK like self-host emit success. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AotEmitFastExit::exitAfterSuccessfulSelfhostEmit()to honorPHP_COMPILER_SPINE_CHUNK=1, not onlytest/selfhost/paths andPHP_COMPILER_SELFHOST_AOT=1.bin/compile.php: call fast-exit after successful emit whenExternalMethodBind::spineChunkMode()is on.SelfhostAotFastExitTest.Why: Spine split-TU hub/consumer chunks (
script/spine-chunk-probe.sh,bootstrap-gen0-chunk-emit.sh) compilebuild/micro/chunk/*.phpwithSPINE_CHUNK=1.bin/compile.phptreats those as user-script AOT and clearsSELFHOST_AOT, so LLVM teardown after a successful-olink could spin 15+ min (#31726) even though the binary was already runnable. This blocked Phase B/C hub manifest export timing out at 600–900s wall (compile + hang).Not in scope: Core hub JIT compile of
spine-chunk-core-requires.txtstill exceeds 10 min on this host — separate compile-time work, not post-emit hang.Closes #36155 (follow-up slice).
Test plan
Made with Cursor