Skip to content

AOT: Reflection getParameters() on runtime internal names + phpcredits true return - #36090

Merged
PurHur merged 1 commit into
masterfrom
agent/aot-reflection-runtime-internal-metadata
Aug 31, 2026
Merged

PurHur merged 1 commit into
masterfrom
agent/aot-reflection-runtime-internal-metadata

Conversation

@PurHur

@PurHur PurHur commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Summary

Verification

./script/aot-smoke.sh
# aot-smoke: 8 passed, 0 failed

./script/docker-exec.sh -- bash -lc 'php bin/compile.php -o /tmp/t.bin test/repro/maintainer_gap_array_diff_intersect_reflection_names.php && /tmp/t.bin'
# matches Zend byte-for-byte

./script/docker-exec.sh -- bash -lc 'php bin/compile.php -o /tmp/t.bin test/repro/maintainer_gap_phpcredits_flag.php && /tmp/t.bin'
# ret=true (not ret=bool)

./script/phpunit.sh --filter Issue23593ReflectionFunctionVariadicAotTest
# OK (4 tests, 11 assertions)

Not run: full differential sweep (139/139 was green on master before this change), release-readiness.sh, north-star5-verify.

Made with Cursor

Embed full internal-function Reflection metadata when getParameters() is
linked so foreach-over-function-name repros compile and match Zend (#23593).
Correct phpcredits stub return label to literal true (#24508). Align JIT
variadic unknown-named-arg errors with VM ArgumentCountError (#23449).

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit 6a8a2ad into master Aug 31, 2026
1 check passed
@PurHur
PurHur deleted the agent/aot-reflection-runtime-internal-metadata branch August 31, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant