Fix DOM AOT getElementById warnings and C14N after mutation - #36087
Merged
Merged
Conversation
Use peek hashtable reads for id-map lookups so missing keys do not emit PHP warnings, refresh compile-time loadXML after LiveSlots append/move (markup- based same-parent move is idempotent on repeat sync), and rebuild C14N fold literals from stamped inner XML when the document literal lags mutations. Closes #29694 Closes #32972 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
peekStringKeyToValueBox(no undefined-index warning) for PROP_ELEMENT_ID_MAP reads inJitDomGetElementByIdand first-wins id-map seeding inJitDomLoadXMLUserScript.compileTimeDomInnerXmlwhen the document literal lags.Verify
Not covered
maintainer_gap_dom_c14n_xpath, nodelist fresh-length) — separate follow-ups.Closes #29694
Closes #32972
Made with Cursor