Skip to content

Fix DOM AOT getElementById warnings and C14N after mutation - #36087

Merged
PurHur merged 1 commit into
masterfrom
fix/dom-aot-c14n-gei-idmap
Aug 31, 2026
Merged

PurHur merged 1 commit into
masterfrom
fix/dom-aot-c14n-gei-idmap

Conversation

@PurHur

@PurHur PurHur commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Summary

Verify

./script/aot-smoke.sh
# aot-smoke: 8 passed, 0 failed

./script/phpunit.sh --filter 'DomC14NAfterMutationAotTest|Issue29694DomGetElementByIdReplaceChildAotTest'
# OK (2 tests, 17 assertions)

Not covered

  • Full compliance / differential sweep (DOM-only AOT unit repros above).
  • SIGSEGV repros (maintainer_gap_dom_c14n_xpath, nodelist fresh-length) — separate follow-ups.

Closes #29694
Closes #32972

Made with Cursor

Use peek hashtable reads for id-map lookups so missing keys do not emit PHP
warnings, refresh compile-time loadXML after LiveSlots append/move (markup-
based same-parent move is idempotent on repeat sync), and rebuild C14N fold
literals from stamped inner XML when the document literal lags mutations.

Closes #29694
Closes #32972

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit 748ac45 into master Aug 31, 2026
1 check passed
@PurHur
PurHur deleted the fix/dom-aot-c14n-gei-idmap branch August 31, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant