AOT: fold SQLite3::open leftover of version (#36001) - #36003
Merged
Conversation
Thin AOT returned null for open(); match zim_sqlite3_open — Exception when already open, reopen after close via PROP_ID. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SQLite3::open()(ExternalMethod stub) after the version fold (AOT: SQLite3::version() returns NULL — leftover of escapeString (#35977) (ext/sqlite3/sqlite3.c) #35991).openwas never registered on the SQLite3 JIT proxy list; already-open / close-reopen never ran.openontoPROP_ID(throwException: Already initialised DB Objectwhen open; re-init afterclose) — same honesty class as__construct.ext/sqlite3/sqlite3.c(zim_sqlite3_open).Test plan
./script/aot-smoke.sh→ 8/8PHP_COMPILER_PROFILE=8.4test/repro/sqlite3_open_aot.php→ identical./script/phpunit.sh --filter 'Sqlite3OpenAotTest|Sqlite3VersionAotTest|Sqlite3BusyTimeoutAotTest'→ OK (6 tests)Priority queue (#32122 / #31968 children / #31962) already closed; this is the next AOT leftover.
Made with Cursor