AOT: lazy HashTable locale/multisort LLVM (#35904) - #35913
Merged
Conversation
Defer ksort/asort SORT_LOCALE_STRING and array_multisort packed LLVM until
first lookup so hello-world no longer NestedJITs strcoll at HashTable init.
Keep strKey natsort eager: lazy first-link skipped the rest of {main}.
Co-authored-by: Cursor <cursoragent@cursor.com>
Keep locale/packed-natural lazy on top of master's ensureMultisortPacked. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ksort/asortSORT_LOCALE_STRINGandarray_multisortpacked HashTable LLVM until first lookup so hello-world no longer NestedJITsstrcollduringHashTable::implement()(ext/standard/array.c/ leftover of php-in-php: lazy strcoll/strnatcmp from HashTable::implement (#35626) #35626).natsortLLVM eager: lazy first-link during user lowering skipped the rest of{main}(empty stdout).memcpy/memset/memmovebodies and scope IniRuntime bridges to the ABI function so AOT smoke stays 8/8 without the old natsort warmup.Closes #35904
php-src: ext/standard/array.c (
php_array_ksort/php_natsort/php_array_multisort); ext/standard/string.c (strcoll/strnatcmp).Test plan
./script/phpunit.sh --filter 'HashTableLazySortAbi35904RuntimeShrinkTest|HashTableLazyStringCompareRuntimeShrinkTest|NatsortPackedPreserveKeys33618AotTest|AsortKsortAot27513Test'— OK (10 tests)./script/aot-smoke.sh— 8 passed, 0 failedphp bin/vm.php/php bin/compile.phpontest/repro/issue_35904_ksort_locale_natsort_multisort.php— identical stdoutDid not run
north-star5-verify --strictor fullmake test-harness.Made with Cursor