Repository navigation
Language: clone() on enum cases throws Error (#3554) - #3570
Merged
Merged
Conversation
Materialize enum case objects on E::Case fetch and reject clone with Zend-aligned Error dispatch instead of LogicException. Register Throwable as Error parent so catch (Throwable) matches. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E::Caseenum fetches now materialize a VMEnumCaseEntry(minimal Zend case object) instead of bare scalar constants, preserving backed-enum echo viaVariable::toString().TYPE_CLONEdetects enum case operands and dispatches a catchableErrorwith messageCannot clone enum case Class::CaseviaBuiltinExceptionSupport::materializeError().Throwableas parent of builtinErrorsocatch (Throwable $e)matches (distinct from readonly-object clone rules in Language: clone() on readonly objects — deep copy + readonly property guards (Zend zend_clones.c parity) #3430).php-src reference
Zend/zend_clones.c— enumclone_objguard / uncloneable object errorZend/zend_enum.c— case object creation onE::CasefetchVerification
Closes #3554
Made with Cursor