Fix AOT undef-var guards for foreach-by-ref and native function locals (re #23471) - #35651
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--aotparity oni11_foreach_by_refande28_float_widen_mul_escapeafter the AOT: undef-var in closures/functions + error_get_last file/line for float deprecations #35643 assigned-flag regressionZEND_CHECK_UNDEFINED_VARfor foreach-by-ref CVs; mark assigned on by-ref iter/assign pathsTest plan
./script/aot-smoke.sh→ 8 passed, 0 failed./script/docker-exec.sh -- bash -lc '…'repro:i11_foreach_by_ref.php+e28_float_widen_mul_escape.phpbyte-identical to Zend./script/phpunit.sh --filter UndefinedVariableClosureAotTest→ OK (1 test, 4 assertions)./script/differential-sweep.sh --aotnot re-run end-to-end this run (prior pass: 123/125; both known DIFF cases fixed individually)Closes #23471
Made with Cursor