AOT DOM: fix DTD isId regression and setIdAttributeNode(null) LLVM verify (#34821, #33758)

[PurHur]

Summary

• AOT: loadXML DTD ATTLIST ID / xml:id leaves Attr::isId() false — Zend true (re-#34696/#29884, ext/dom/attr.c) #34821: Restore isIdBearingLiteral before the activeFunction guard in DomAttrIsId so loadXML DTD ATTLIST ID attributes report DOMAttr::isId() === true under thin AOT again (regressed in Fix AOT DOMAttr::isId() on createElement thin-AOT trees (#29884) #35627).
• AOT: DOMElement::setIdAttributeNode(null) skips TypeError — Zend TypeError (ext/dom/element.c) #33758: Rework setIdNode*Argv to a single-Attr Context bridge (JitVmHelperLink::ensureContextBridge) — nested JIT mis-lowers two consecutive ObjectEntry LLVM params and module-verify failed on PHP_COMPILER_HELPER_RUNTIME_O=0 compiles. Add VmDom::setIdAttributeNodeOnAttrOwner for the helper body.

php-src: ext/dom/attr.c (dom_attr_is_id), ext/dom/element.c (setIdAttributeNode).

Test plan

./script/aot-smoke.sh
# 8 passed, 0 failed

PHP_COMPILER_HELPER_RUNTIME_O=0 ./script/phpunit.sh --filter 'DomSetIdAttrNodeNull33758AotTest|Issue34821DomDtdIsIdAotTest|DomAttrIsIdCreateElementAotTest'
# OK (5 tests, 20 assertions)

Not covered: prelinked/helper-runtime/.../DomSetIdAttributeJitHelper unit refresh (signature changed — run php script/emit-helper-runtime-object.php --unit /ext/dom/DomSetIdAttributeJitHelper.php before relying on default PHP_COMPILER_HELPER_RUNTIME_O=1 cache). Targeted tests above use PHP_COMPILER_HELPER_RUNTIME_O=0 explicitly.

Closes #34821
Closes #33758

Made with Cursor