Stdlib: ext/sqlsrv — sqlsrv_connect()/sqlsrv_query() SQL Server driver (#6577) - #35597
Merged
Conversation
Add phase-1 sqlsrv module so function_exists probes succeed and invalid connect returns false with structured sqlsrv_errors() when the Microsoft ODBC driver is absent (php-src ext/sqlsrv). Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/sqlsrv/with phase-1 procedural builtins:sqlsrv_connect,sqlsrv_close,sqlsrv_query,sqlsrv_fetch_array,sqlsrv_errors.function_exists('sqlsrv_*')is true; invalid connect returnsfalseand populates structuredsqlsrv_errors()(IMSSP/-49) when the Microsoft ODBC driver is absent — matches php-srcext/sqlsrventerprise probe pattern.ExtensionRegistry(83 extensions) and capability matrix (+5 builtins → 1172).php-src reference
ext/sqlsrv/php_sqlsrv.c— module init / function registrationext/sqlsrv/shared/core_conn.cpp— connect + error propagationVerification
Note:
VMTestdata provider currently errors on an unrelated PHPTEXTENSIONSsection on master; repro verified viabin/vm.phpinline above and committedtest/compliance/cases/stdlib/sqlsrv_functions_exist.phpt.Closes #6577
Made with Cursor