Skip to content

php-in-php: lazy StringFormat from ensureFullStandaloneBodies (#35130) - #35134

Merged
PurHur merged 1 commit into
masterfrom
fix/35130-lazy-stringformat-ensurefull
Aug 26, 2026
Merged

PurHur merged 1 commit into
masterfrom
fix/35130-lazy-stringformat-ensurefull

Conversation

@PurHur

@PurHur PurHur commented Aug 26, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #35130

Test plan

  • ./script/phpunit.sh --filter 'ContextFullStandaloneLazyStringFormatShrinkTest|ContextFullStandaloneLazyGetenvShrinkTest|ContextFullStandaloneLazyRandomBytesShrinkTest|ContextFullStandaloneLazyJsonOffsetShrinkTest|ContextFullStandaloneLazyExceptionErrorBridgeRuntimeShrinkTest|TypeDeadFormatAbiRuntimeShrinkTest|StringFormatRuntimeStandaloneTest' → OK (27 tests)
  • ./script/aot-smoke.sh → 8/8
  • AOT echo "hi"hi
  • AOT sprintf("%s","ok")ok
  • AOT number_format(1234.5,2)1,234.50
  • AOT printf("%s\n","ok")ok

Made with Cursor

Drop always-on NestedJIT of sprintf/printf/number_format during full
standalone init; call sites already implementIfDeclared/ensureLinked
(#32122 .1 mint class; peer #35127).

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit d6f4880 into master Aug 26, 2026
@PurHur
PurHur deleted the fix/35130-lazy-stringformat-ensurefull branch August 26, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

php-in-php: drop Context ensureFullStandaloneBodies always-on StringFormat — lazy at JitSprintf/Printf/NumberFormat (ext/standard/formatted_print.c)

1 participant