php-in-php: lazy ExceptionBridge/ErrorBridge from ensureFull (#35099) - #35101
Merged
Merged
Conversation
Drop always-on NestedJIT of pending TypeError/Error ABIs from Context::ensureFullStandaloneBodies (peer #34732/#34769) and delete the dead string-helpers gate that never ran under beginStandaloneInitPhase. Standalone {main} already ensureLinked before clear/abort (#32122 .1 mint). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExceptionBridge/ErrorBridgeNestedJIT fromContext::ensureFullStandaloneBodies(peer php-in-php: drop Context ensureMinimalUserStandaloneBodies always-on ExceptionBridge — lazy at TypeErrorRaise call sites (peer #34695) #34732 / php-in-php: drop Context ensureMinimalUserStandaloneBodies always-on ErrorBridge — lazy at ErrorRaise/ReadonlyRaise call sites (peer #34732) #34769 on the minimal path).!isStandaloneInitPhase()—ensureFullalways begins that phase first, so those calls never ran; call sites alreadyensureLinked.{main}alreadyErrorBridge::ensureLinked/emitClear|emitAbort→ensureLinkedbefore lookup (Release v1.1.0: fix cold-build-check compile_failed on hello world (LLVM Module.php line 180; re-#24302) #32122.1mint class). Replaces already-deletedphpc_type_error_raise.c/phpc_error_raise.c.Closes #35099
Test plan
./script/phpunit.sh --filter 'ContextFullStandaloneLazyExceptionErrorBridge|ContextMinimalStandaloneLazyExceptionBridge|ContextMinimalStandaloneLazyErrorBridge|ContextFullStandaloneLazyStdlib'→ OK (17 tests, 154 assertions)./script/docker-exec.sh -- bash -lc './script/aot-smoke.sh'→ aot-smoke: 8 passed, 0 failedci-local/north-star5-verify --strictphp-src:
Zend/zend_exceptions.c,Zend/zend_error.cMade with Cursor