php-in-php: lazy Utf8Latin1/RewriteVars/Define/Strspn/FileGetContents/Readfile from ensureFull (#35089) - #35092
Merged
Merged
Conversation
…/Readfile from ensureFull (#35089) Drop always-on NestedJIT of those stdlib ABIs from Context::ensureFullStandaloneBodies (peer #34578 / #35086). BootstrapCompileSmokeM3Emit now ensureLinked StringFileGetContents before __compiler_file_get_contents lookup so inventory argv still links (#15604 / #32122 .1 mint). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StringUtf8Latin1/RewriteVarsRuntime/DefineRuntime/StringStrspn/StringFileGetContents/StringReadfilefromContext::ensureFullStandaloneBodies(peer ensureMinimal php-in-php: drop Context ensureMinimalUserStandaloneBodies always-on stdlib NestedJIT batch — lazy Jit* ABI (peer #34566) #34578; ensureFull Stream* php-in-php: lazy StreamLifecycle/StreamRead/StreamFilter/StreamBucket + FunctionStatic from ensureFullStandaloneBodies (Context.php) #35086).BootstrapCompileSmokeM3Emit::emitSourceReadOrFailnowStringFileGetContents::ensureLinkedbefore__compiler_file_get_contentslookup (Gen-1+ #8: Inventory argv driver without emit-helper sidecar TU (#2866) #15604) so inventory argv still links after the Context drop..1mint class).php-src
ext/standard/file.c— file_get_contents / readfileext/standard/basic_functions.c— define / utf8_encode/decodeext/standard/string.c— strspn / strcspnTest plan
./script/aot-smoke.sh→ 8 passed, 0 failed./script/phpunit.sh --filter 'ContextFullStandaloneLazyStdlib|ContextMinimalStandaloneLazyStdlib|ContextFullStandaloneLazyStream|TypeDeadFileGetContents|TypeDeadReadfile|TypeDeadUtf8Latin1'→ OK (21 tests)define/strspn/file_get_contents/readfile/echo hi→ matchPHP_COMPILER_HELPER_RUNTIME_O=0 php bin/compile.php -o /tmp/hw.bin -r 'echo "hi";'→hiMade with Cursor