php-in-php: lazy Json + Offset/ScalarDim from ensureFull (#35065) - #35068
Merged
Conversation
Drop always-on NestedJIT of StringJsonEncode/Decode and ScalarDim/StringOffset during full standalone init; call sites already ensureLinked (#32122 .1 class). Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StringJsonEncode/StringJsonDecode/ScalarDimFetchRuntime/StringOffsetRuntimefromContext::ensureFullStandaloneBodiesso full standalone init cannot mint*.1ABIs (Release v1.1.0: fix cold-build-check compile_failed on hello world (LLVM Module.php line 180; re-#24302) #32122 / Fix: AOT link fails for EVERY binary — duplicate memset declaration #31894).ensureLinked/ensureJitHelperCompiledbefore lookup or emit (peer php-in-php: drop Context ensureFullStandaloneBodies always-on TokenGetAll/Highlight/Hebrev/Hebrevc + SuperglobalNameRuntime #35035).lib/AOT/runtime/*.c.Closes #35065
php-src
ext/json/php_json.c—php_json_encode/php_json_decodeZend/zend_operators.c— string offset / scalar dim warningsTest plan
./script/phpunit.sh --filter ContextFullStandaloneLazyJsonOffsetShrinkTest→ OK (4 tests)./script/aot-smoke.sh→ 8/8PHP_COMPILER_HELPER_RUNTIME_O=0 php bin/compile.php -o /tmp/hw.bin -r 'echo "hi";'→hi$s[1]+ scalar-dim warn matches Zend on the same probeMade with Cursor